Fix bug in regex which removed newlines

command-manager.go

@@ -9,9 +9,10 @@ package disgoman
 import (
 	"errors"
 	"fmt"
-	"github.com/bwmarrin/discordgo"
+	"regexp"
-	"github.com/kballard/go-shellquote"
 	"strings"
+
+	"github.com/bwmarrin/discordgo"
 )
 
 // AddCommand adds the Command at the address passed in to the Commands array on the CommandManager.
@@ -90,30 +91,24 @@ func (c *CommandManager) OnMessage(session *discordgo.Session, m *discordgo.Mess
 
 	guild, _ := session.Guild(m.GuildID)
 
+	ctx := Context{
+		Session:      session,
+		Channel:      channel,
+		Message:      m.Message,
+		User:         m.Author,
+		Guild:        guild,
+		Member:       m.Member,
+		Invoked:      "",
+		ErrorChannel: c.ErrorChannel,
+	}
+
 	var cmd []string
 	// If we found our prefix then remove it and split the command into pieces
-	cmd, err = shellquote.Split(strings.TrimPrefix(content, prefix))
+	content = strings.TrimPrefix(content, prefix)
-	if err != nil {
+	r := regexp.MustCompile(`[^ "]+|"([^"]*)"`)
-		if err.Error() == "Unterminated double-quoted string" || err.Error() == "Unterminated single-quoted string" {
+	cmd = r.FindAllString(content, -1)
-			cmd = strings.Split(strings.TrimPrefix(content, prefix), " ")
+	for i, val := range cmd {
-		} else {
+		cmd[i] = strings.Trim(val, "\"")
-			ctx := Context{
-				Session:      session,
-				Channel:      channel,
-				Message:      m.Message,
-				User:         m.Author,
-				Guild:        guild,
-				Member:       m.Member,
-				Invoked:      "",
-				ErrorChannel: c.ErrorChannel,
-			}
-			c.ErrorChannel <- CommandError{
-				Context: ctx,
-				Message: "",
-				Error:   err,
-			}
-			return
-		}
 	}
 
 	if len(cmd) < 1 {
@@ -121,8 +116,8 @@ func (c *CommandManager) OnMessage(session *discordgo.Session, m *discordgo.Mess
 	}
 
 	var command *Command
-	invoked := cmd[0]
+	ctx.Invoked = cmd[0]
-	if cmnd, ok := c.Commands[invoked]; ok {
+	if cmnd, ok := c.Commands[ctx.Invoked]; ok {
 		command = cmnd
 	} else {
 		fmt.Println("Command Not Found")
@@ -137,16 +132,6 @@ func (c *CommandManager) OnMessage(session *discordgo.Session, m *discordgo.Mess
 	}
 
 	if !CheckPermissions(session, m.Author.ID, *channel, command.RequiredPermissions) {
-		ctx := Context{
-			Session:      session,
-			Channel:      channel,
-			Message:      m.Message,
-			User:         m.Author,
-			Guild:        guild,
-			Member:       m.Member,
-			Invoked:      cmd[0],
-			ErrorChannel: c.ErrorChannel,
-		}
 		c.ErrorChannel <- CommandError{
 			Context: ctx,
 			Message: "You don't have the correct permissions to run this command.",
@@ -156,16 +141,6 @@ func (c *CommandManager) OnMessage(session *discordgo.Session, m *discordgo.Mess
 	}
 
 	if !CheckPermissions(session, session.State.User.ID, *channel, command.RequiredPermissions) {
-		ctx := Context{
-			Session:      session,
-			Channel:      channel,
-			Message:      m.Message,
-			User:         m.Author,
-			Guild:        guild,
-			Member:       m.Member,
-			Invoked:      cmd[0],
-			ErrorChannel: c.ErrorChannel,
-		}
 		c.ErrorChannel <- CommandError{
 			Context: ctx,
 			Message: "I don't have the correct permissions to run this command.",
@@ -176,16 +151,6 @@ func (c *CommandManager) OnMessage(session *discordgo.Session, m *discordgo.Mess
 	}
 
 	if command.OwnerOnly && !c.IsOwner(m.Author.ID) {
-		ctx := Context{
-			Session:      session,
-			Channel:      channel,
-			Message:      m.Message,
-			User:         m.Author,
-			Guild:        guild,
-			Member:       m.Member,
-			Invoked:      cmd[0],
-			ErrorChannel: c.ErrorChannel,
-		}
 		c.ErrorChannel <- CommandError{
 			Context: ctx,
 			Message: "Sorry, only the bot owner(s) can run that command!",
@@ -195,16 +160,5 @@ func (c *CommandManager) OnMessage(session *discordgo.Session, m *discordgo.Mess
 
 	}
 
-	context := Context{
+	go command.Invoke(ctx, cmd[1:])
-		Session:      session,
-		Channel:      channel,
-		Message:      m.Message,
-		User:         m.Author,
-		Guild:        guild,
-		Member:       m.Member,
-		Invoked:      invoked,
-		ErrorChannel: c.ErrorChannel,
-	}
-
-	go command.Invoke(context, cmd[1:])
 }